Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not call renderFullIImage for IIIF image #2487

Merged
merged 3 commits into from
Nov 22, 2024
Merged

fix: do not call renderFullIImage for IIIF image #2487

merged 3 commits into from
Nov 22, 2024

Conversation

LeoniePeters
Copy link
Contributor

No description provided.

@LeoniePeters
Set fullImageRendered data prop before anno highlight and only render…
4d9a3ca 
… full image when needed on keyboard interaction
@github-actions GitHub Actions
Copy link

Preview deployment: https://pr-2487.portal-js.dev.eanadev.org/

rwd and others added 2 commits November 21, 2024 13:51
@rwd
refactor: handle keydown event in image viewer
ba401d5 
for loading fullscreen image, so kb toggle doesn't need to know about it
@LeoniePeters
Only listen to keydown when no full image rendered
5c80e2f
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@rwd rwd mentioned this pull request Nov 22, 2024
Closed
@rwd rwd merged commit 6d71495 into master Nov 22, 2024
17 checks passed
@rwd rwd deleted the fix/only-full-image-on-static-source branch November 22, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwd rwd rwd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LeoniePeters @rwd